NO-JIRA: Introduce version annotation test for Windows nodes #29190
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jrvaldes: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/CC @deads2k |
jrvaldes
force-pushed
the
windows-add-version-anno-test
branch
from
426716e
to
6c56ca7
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/test ? |
|
@jrvaldes: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/test lint |
|
/test unit |
|
/test verify |
|
/approve |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/retest-required |
openshift-ci
bot
added
the
approved
|
/tide refresh |
This commit introduces a new group of extended tests for Windows nodes and add a tests to check the required version annotation in Windows nodes. Ran: ``` ./hack/update-generated.sh ```
jrvaldes
force-pushed
the
windows-add-version-anno-test
branch
from
6c56ca7
to
aa74be8
Compare
|
/CC @openshift/openshift-team-windows-containers |
|
@jrvaldes: GitHub didn't allow me to request PR reviews from the following users: openshift/openshift-team-windows-containers. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm Thanks for doing this @jrvaldes! |
|
Job Failure Risk Analysis for sha: aa74be8
|
|
@jrvaldes: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, jrvaldes, saifshaikh48, sebsoto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@deads2k please consider overriding the failed tests as they are unrelated to the proposed change. |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/tide refresh |
|
/test e2e-aws-ovn-ipsec-serial |
|
@jrvaldes: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
This PR proposes a new group of tests targeting Windows nodes in the test cluster and introduces a simple Windows-specific check as the first step in providing test coverage for Windows nodes.